Extract test fixtures to separate header #55056
Open
+442
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Summary: Pull Request resolved: facebook#55055 TSIA. Changelog: [Internal] Differential Revision: D90174644 Reviewed By: robhogan
Summary: Pull Request resolved: facebook#55056 Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split `InspectorPackagerConnectionTest.cpp` into multiple files as we add more test cases, which is particularly helpful for LLMs writing tests. Changelog: [Internal] Reviewed By: robhogan Differential Revision: D90174645
motiz88
force-pushed
the
export-D90174645
branch
from
ca830a9 to
f4f1b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors InspectorPackagerConnectionTest.cpp to extract the test fixtures into a separate header file. This allows us to split
InspectorPackagerConnectionTest.cppinto multiple files as we add more test cases, which is particularly helpful for LLMs writing tests.Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D90174645