Skip to content

fix(ios): custom font not applied correctly in v0.83 #55071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amitkumar-source wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

fix(ios): custom font not applied correctly in v0.83 #55071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .../renderer/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTFontUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,16 +359,12 @@ static UIFontDescriptorSystemDesign RCTGetFontDescriptorSystemDesign(NSString *f
// Gracefully handle being given a font name rather than font family, for
// example: "Helvetica Light Oblique" rather than just "Helvetica".
font = [UIFont fontWithName:fontProperties.family size:effectiveFontSize];
if (font != nullptr) {
fontNames = [UIFont fontNamesForFamilyName:font.familyName];
fontWeight = (fontWeight != 0.0) ?: RCTGetFontWeight(font);
} else {

if (!font) {
// Failback to system font.
font = RCTDefaultFontWithFontProperties(fontProperties);
}
}

if (fontNames.count > 0) {
} else {
// Get the closest font that matches the given weight for the fontFamily
CGFloat closestWeight = INFINITY;
for (NSString *name in fontNames) {
Expand Down