Skip to content

fix(android): fix XMLHttpRequest timeout error trigger onerror instead of ontimeout #55080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weihanyau wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

fix(android): fix XMLHttpRequest timeout error trigger onerror instead of ontimeout #55080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b494b
fix(android): fix ontimeout
weihanyau Jan 7, 2026
a9ef205
fix(android): fix tcp ontimeout
weihanyau Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import com.facebook.react.bridge.WritableMap
import com.facebook.react.bridge.buildReadableArray
import com.facebook.react.common.build.ReactBuildConfig
import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
import java.io.InterruptedIOException
import java.net.SocketTimeoutException
import okhttp3.Headers
import okhttp3.Protocol
Expand Down Expand Up @@ -197,7 +198,7 @@ internal object NetworkEventUtil {
buildReadableArray {
add(requestId)
add(error)
if (e?.javaClass == SocketTimeoutException::class.java) {
if (e?.javaClass == SocketTimeoutException::class.java || e?.javaClass === InterruptedIOException::class.java) {
add(true) // last argument is a time out boolean
}
},
Expand Down