Remove shouldResetClickableWhenRecyclingView feature flag #55106
+37
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We decided not to pursue the approach of setting `isClickable=true` by default on all React Native views (Option 1 in the design doc). While this would improve UI harvesting detection for Gaze-based interaction, propagating the pointer events semantics on the whole hierarchy to keep `isClickable` in sync with each node's `pointerEvents` value is expensive (O(N) in worst case for hierarchy construction, reparenting, and dynamic pointerEvents updates). Instead, we will pursue Option 2: deriving `importantForInteraction` from pointer events, which doesn't require updating `isClickable` at all. See design doc: https://docs.google.com/document/d/15Fi47zOHQh--KFWLUxQAUmBENgnZ0ZkYsKyOshPzBAo/edit?tab=t.0#heading=h.61xuoxksjdrp Changes: - Removed the `shouldSetIsClickableByDefault` flag from `ReactNativeFeatureFlags.config.js` - Removed the `configureClickableState` method from `BaseViewManager.java` - Removed the call to `configureClickableState` from `onAfterUpdateTransaction` - Regenerated all feature flag files via `js1 featureflags --update` Differential Revision: D90378897
Summary: Changelog: [Android][Fixed] - Reset isClickable to false when recycling views to avoid accessibility tools finding views with incorrect state --- This diff removes the `shouldResetClickableWhenRecyclingView` feature flag since it has been tested in FB4A for a month with `defaultValue: true`. The flag was introduced to reset `isClickable` to false when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling. This behavior is now the default. Changes: - Removed the flag definition from `ReactNativeFeatureFlags.config.js` - Removed the conditional check in `BaseViewManager.java`, now `view.setClickable(false)` is always called unconditionally - Regenerated all feature flag files via `js1 featureflags --update` Reviewed By: javache Differential Revision: D90380899
meta-cla
bot
added
the
CLA Signed
|
@fabriziocucci has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90380899. |
|
This pull request has been merged in 07c0539. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android][Fixed] - Reset isClickable to false when recycling views to avoid accessibility tools finding views with incorrect state
This diff removes the
shouldResetClickableWhenRecyclingViewfeature flag since it has been tested in FB4A for a month withdefaultValue: true.The flag was introduced to reset
isClickableto false when recycling views on Android to avoid accessibility tools finding views with incorrect state after recycling. This behavior is now the default.Changes:
ReactNativeFeatureFlags.config.jsBaseViewManager.java, nowview.setClickable(false)is always called unconditionallyjs1 featureflags --updateReviewed By: javache
Differential Revision: D90380899