Wire native CSS parsing for fontVariant#55684
Open
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Open
Wire native CSS parsing for fontVariant#55684NickGerleman wants to merge 3 commits intofacebook:mainfrom
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Conversation
Summary: Gate `processTransformOrigin` behind `enableNativeCSSParsing()`. When the flag is on, CSS transform-origin strings like `"top left"` or `"10px 50%"` are parsed natively using the existing CSS transform-origin parser instead of being preprocessed in JS. Changelog: [Internal] Differential Revision: D94052730
Summary: Gate `processAspectRatio` behind `enableNativeCSSParsing()`. When the flag is on, CSS ratio strings like `"16/9"` and number strings are parsed natively using the existing CSS ratio parser instead of being preprocessed in JS. The parsing is done in `fromRawValue(... FloatOptional &)` — string values are only sent for aspectRatio; other FloatOptional yoga props never receive strings from JS. Changelog: [Internal] Differential Revision: D94052732
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94052733. |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Gate `processFontVariant` behind `enableNativeCSSParsing()`. When the flag is on, CSS font-variant strings like `"small-caps oldstyle-nums"` are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS. Also removes `react_native_expect(false)` hard error on unknown font variant values, replacing it with a graceful skip. Changelog: [Internal] Differential Revision: D94052733
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Gate `processFontVariant` behind `enableNativeCSSParsing()`. When the flag is on, CSS font-variant strings like `"small-caps oldstyle-nums"` are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS. Also removes `react_native_expect(false)` hard error on unknown font variant values, replacing it with a graceful skip. Changelog: [Internal] Differential Revision: D94052733
Summary: Pull Request resolved: facebook#55684 Gate `processFontVariant` behind `enableNativeCSSParsing()`. When the flag is on, CSS font-variant strings like `"small-caps oldstyle-nums"` are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS. Also removes `react_native_expect(false)` hard error on unknown font variant values, replacing it with a graceful skip. Changelog: [Internal] Differential Revision: D94052733
NickGerleman
force-pushed
the
export-D94052733
branch
from
71b3a4d to
3bb564b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Gate
processFontVariantbehindenableNativeCSSParsing(). When the flag is on, CSS font-variant strings like"small-caps oldstyle-nums"are parsed natively using the existing CSS font-variant parser instead of being preprocessed in JS.Also removes
react_native_expect(false)hard error on unknown font variant values, replacing it with a graceful skip.Changelog: [Internal]
Differential Revision: D94052733