Deprecate and replace obscure ShadowNode type aliases#55690
Open
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Open
Deprecate and replace obscure ShadowNode type aliases#55690sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
force-pushed
the
export-D90331677
branch
from
2878c9d to
b224510
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
force-pushed
the
export-D90331677
branch
from
b224510 to
cb82dfe
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
force-pushed
the
export-D90331677
branch
from
cb82dfe to
c19b183
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 24, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
Summary: Remove deprecated type aliases that are no longer used: - `SharedImageManager` → use `std::shared_ptr<ImageManager>` - `ContextContainer::Shared` → use `std::shared_ptr<const ContextContainer>` These were previously removed, brought back as deprecated for compatibility, and now have no remaining usages. Differential Revision: D90331219
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
force-pushed
the
export-D90331677
branch
from
c19b183 to
8a88c49
Compare
Summary: Pull Request resolved: facebook#55690 Changelog: [internal] Mark these obscure type aliases as deprecated and replace all usages with explicit types: - `ShadowNode::SharedListOfShared` → `std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfShared` → `std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>` - `ShadowNode::UnsharedListOfWeak` → `std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>` the type aliases will be deleted later. Reviewed By: lenaic Differential Revision: D90331677
sammy-SC
force-pushed
the
export-D90331677
branch
from
8a88c49 to
27dc591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Mark these obscure type aliases as deprecated and replace all usages with explicit types:
ShadowNode::SharedListOfShared→std::shared_ptr<const std::vector<std::shared_ptr<const ShadowNode>>>ShadowNode::UnsharedListOfShared→std::shared_ptr<std::vector<std::shared_ptr<const ShadowNode>>>ShadowNode::UnsharedListOfWeak→std::shared_ptr<std::vector<std::weak_ptr<const ShadowNode>>>the type aliases will be deleted later.
Reviewed By: lenaic
Differential Revision: D90331677