Fix crash on reload#56594
Open
etodanik wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Revert crash on reload caused by facebook@45b4817#diff-99e9fee4dbe9d329e2f7df16035fb871fa583c92028a48fefb1c48e405638944R314-R316
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert crash on reload caused by 45b4817#diff-99e9fee4dbe9d329e2f7df16035fb871fa583c92028a48fefb1c48e405638944R314-R316
Summary:
@j-piasecki your change that seems redundant for the destructor case (reactInstanceData_ is a unique pointer and will be destroyed anyway) and breaks the reload case (by setting
contextContainertonullptr, which is then immediately accessed bycreateReactInstance, causing a crash)Changelog:
[GENERAL] [FIXED] - Fixed a regression that causes crashes on reload for
ReactCxxPlatform'sReactHostTest Plan:
Reload the development server