fix(ios): fix broken transitions with autoFocus=true by moving to viewDidAppear

[hannojg]

Summary:

Fixes:

• [iOS] TextInput autoFocus called in didMoveToWindow causing transition glitches with UIKit #56595

Caution

This is based on the following PRs which should be merged first:

• feat(ios): RCTViewControllerAppearanceListener #56598
• (optional) change(ios): make root VC notify on viewDidAppear/-Disappear #56618
• Add enableIOSExperimentalAutoFocusImplementation feature flag #56619

When feature flag enableIOSExperimentalAutoFocusImplementation is enabled on iOS we will not request focus to the input (calling becomeFirstResponder) in didMoveToWindow but in viewDidAppear of the parent's view controller.

This will make the keyboard appear after any UIKit transitions are done, however, it will fix any glitches with the transition.
This is especially relevant for third party navigation libraries, such as react-native-screens:

• [Ios] app lags/stutters while navigating to a new screen with auto focused text input software-mansion/react-native-screens#1637

Changelog:

[IOS] [FIXED] - Fixed #56595 app lags/stutters while navigating to a new screen with auto focused text input

Test Plan:

Try switching the autoFocus prop in the RN tester app. See those recordings

With the feature flag enabled

Note: In the PR that adds the viewDidAppear listener pattern we call any listener immediately on registration if the VC already appeared. Due to that, although the input is already on the screen, the autoFocus still works as with the feature flag disabled.

w_featureflag_compressed.mp4

Without feature flag

wo_featureflag_compressed.mp4

[github-actions]

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

• Please include a clear changelog message.
• This change will be subject to additional review.

This change was flagged as: POTENTIALLY_BREAKING