Fix LayoutAnimation crash from mutation sort ordering#56629
Open
fkgozali wants to merge 1 commit intofacebook:mainfrom
Open
Fix LayoutAnimation crash from mutation sort ordering#56629fkgozali wants to merge 1 commit intofacebook:mainfrom
fkgozali wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: `LayoutAnimationDriver::animationMutationsForFrame` was sorting animation-frame Update mutations together with structural mutations (Remove/Insert/Delete) from completed animations. Animation-frame Updates reference views by their pre-structural-change parentTag. When `std::stable_sort` reordered these Updates after Remove/Insert pairs that reparented a view, `StubViewTree::mutate` hit a parentTag mismatch assertion (`react_native_assert(oldStubView->parentTag == mutation.parentTag)`) and crashed with SIGABRT. The fix records the boundary between animation-frame Updates and final structural mutations, then only sorts the structural portion. This preserves the invariant that animation-frame Updates execute before any structural changes. Additionally, the mutation comparator in `utils.h` was missing an explicit `Update < Insert` ordering rule, which could cause nondeterministic sort results between Update and Insert mutations of different types. This is now handled. The test fixture is converted to `TEST_F` with a `LayoutAnimationTest` class that enables the `fixDifferentiatorParentTagForUnflattenCase` feature flag, ensuring consistent parentTag assignment across platforms. Changelog: [Internal] Differential Revision: D102696875
meta-cla
Bot
added
the
CLA Signed
|
@fkgozali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102696875. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
LayoutAnimationDriver::animationMutationsForFramewas sorting animation-frame Update mutations together with structural mutations (Remove/Insert/Delete) from completed animations. Animation-frame Updates reference views by their pre-structural-change parentTag. Whenstd::stable_sortreordered these Updates after Remove/Insert pairs that reparented a view,StubViewTree::mutatehit a parentTag mismatch assertion (react_native_assert(oldStubView->parentTag == mutation.parentTag)) and crashed with SIGABRT.The fix records the boundary between animation-frame Updates and final structural mutations, then only sorts the structural portion. This preserves the invariant that animation-frame Updates execute before any structural changes.
Additionally, the mutation comparator in
utils.hwas missing an explicitUpdate < Insertordering rule, which could cause nondeterministic sort results between Update and Insert mutations of different types. This is now handled.The test fixture is converted to
TEST_Fwith aLayoutAnimationTestclass that enables thefixDifferentiatorParentTagForUnflattenCasefeature flag, ensuring consistent parentTag assignment across platforms.Changelog: [Internal]
Differential Revision: D102696875