Remove getWindowDisplayMetrics from DisplayMetricsHolder#56635
Open
zoontek wants to merge 1 commit intofacebook:mainfrom
Open
Remove getWindowDisplayMetrics from DisplayMetricsHolder#56635zoontek wants to merge 1 commit intofacebook:mainfrom
zoontek wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
zoontek
commented
Apr 28, 2026
| @Before | ||
| fun setUp() { | ||
| context = RuntimeEnvironment.getApplication() | ||
| DisplayMetricsHolder.setWindowDisplayMetrics(null) |
Contributor
Author
There was a problem hiding this comment.
PixelUtil.kt is not using window display metrics since this commit. Those can be safely removed.
zoontek
commented
Apr 28, 2026
| layout.text, | ||
| layout, | ||
| DisplayMetricsHolder.getWindowDisplayMetrics(), | ||
| DisplayMetricsHolder.getScreenDisplayMetrics(), |
Contributor
Author
There was a problem hiding this comment.
This is OK, as it's only used for screen density
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Following #53254
Removes the deprecated
getWindowDisplayMetrics/setWindowDisplayMetrics/getDisplayMetricsWritableMapAPIs fromDisplayMetricsHolder. These were markedTODO(0.87)for removal once the non-breaking window closed.Changelog:
[ANDROID] [REMOVED] - Remove
DisplayMetricsHolder.getWindowDisplayMetrics,setWindowDisplayMetrics, andgetDisplayMetricsWritableMapTest Plan:
./gradlew :packages:react-native:ReactAndroid:testpasses (removedDisplayMetricsHolderTestwindow-metrics cases and thePixelUtilTestreferences)