[compiler] Improve error messages for unhandled terminal and instruction kinds#32324
Merged
poteto merged 1 commit intofacebook:mainfrom Feb 7, 2025
Merged
[compiler] Improve error messages for unhandled terminal and instruction kinds#32324poteto merged 1 commit intofacebook:mainfrom
poteto merged 1 commit intofacebook:mainfrom
Conversation
inottn
force-pushed
the
compiler/error
branch
from
50cc027 to
6a89187
Compare
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the error message, as the value is currently an object instead of a string, which results in it being converted to '[object Object]'.
How did you test this change?
Already tested locally.