[DevTools] Update ReadMe Docs For WebExtensions#34496
[DevTools] Update ReadMe Docs For WebExtensions#34496ospira wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @ospira! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
All three browser extension ReadMe files reference a path (
shells/webextension) for common source code that I believe no longer exists.I have a guess where the correct path now is, but given it should be easy for the maintainers to make this correction themselves (accurately and without guessing), I'm simply flagging it.
Thus for this PR to be completed it would need to replace the struck out characters with an updated, correct path. If I have made a mistake I apologize, but as you can see in that screenshot I could not find
shells/webextension... I was able to find a top-levelshellsdirectory in the git history, but I must admit the git history is a little confusing, perhaps because this code used to live in a separate repo once upon a time?In any event, it would be great if one of the maintainers could spend a few minutes confirm the issue and give a quick update for people coming to this fresh who want to dive into this particular aspect of the source code. Thanks for your time!
How did you test this change?
N/A