Skip to content

[DevTools] chore: read from build/COMMIT_SHA fle as fallback for commit hash#34915

Merged
hoxyq merged 1 commit intofacebook:mainfrom
hoxyq:commithashfallback
Oct 20, 2025
Merged

[DevTools] chore: read from build/COMMIT_SHA fle as fallback for commit hash#34915
hoxyq merged 1 commit intofacebook:mainfrom
hoxyq:commithashfallback

Conversation

@hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Oct 19, 2025 •
edited
Loading

This eliminates the gap in a reproducer for the React DevTools browser extension from the source code that we submit to Firefox extension stores.

We use the commit hash as part of the Backend version, here:

react/packages/react-devtools-extensions/utils.js

Lines 26 to 38 in 2cfb221

function getVersionString(packageVersion = null) {
if (packageVersion == null) {
packageVersion = JSON.parse(
readFileSync(
resolve(__dirname, '..', 'react-devtools-core', './package.json'),
),
).version;
}
const commit = getGitCommit();
return `${packageVersion}-${commit}`;
}

The problem is that we archive the source code for Mozilla extension store reviews and there is no git. But since we still download the React sources from the CI, we could reuse the hash from build/COMMIT_HASH file.

@hoxyq hoxyq requested a review from eps1lon October 19, 2025 22:06
@meta-cla meta-cla bot added the CLA Signed label Oct 19, 2025
@hoxyq hoxyq force-pushed the commithashfallback branch 2 times, most recently from 69e54d3 to 8ded4fc Compare October 19, 2025 22:15
eps1lon
eps1lon reviewed Oct 20, 2025
View reviewed changes
packages/react-devtools-extensions/utils.js Outdated
// Return short hash (first 7 characters) to match abbreviated commit hash format
return commitHash.slice(0, 7);
}
} catch (readError) {}
Copy link
Collaborator

@eps1lon eps1lon Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warn here maybe since that will just silently produce a different artifact if it fails for Moz people, no?

Copy link
Contributor Author

@hoxyq hoxyq Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Will fail the build script, instead of swallowing the error.

@hoxyq hoxyq force-pushed the commithashfallback branch from 8ded4fc to 85893ea Compare October 20, 2025 12:37
@hoxyq hoxyq merged commit aaad0ea into facebook:main Oct 20, 2025
240 checks passed
@hoxyq hoxyq deleted the commithashfallback branch October 20, 2025 15:14
@nextjs-bot nextjs-bot mentioned this pull request Oct 20, 2025
Merged
@hoxyq hoxyq mentioned this pull request Oct 20, 2025
Merged
hoxyq added a commit that referenced this pull request Oct 20, 2025
@hoxyq
React DevTools 7.0.0 -> 7.0.1 (#34926)
3cde211 
Full list of changes:

* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[#34925](#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[#34915](#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[#34913](#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[#34921](#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[#34922](#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[#34918](#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[#34916](#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34907](#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[#34898](#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[#34893](#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34892](#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[#34885](#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[#34881](#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[#34894](#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[#34880](#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[#34876](#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[#34878](#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[#34873](#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[#34870](#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[#34869](#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[#34867](#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [#34860](#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[#34861](#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[#34859](#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[#34854](#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[#34853](#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[#34852](#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[#34851](#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[#34850](#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[#34828](#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[#34756](#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[#34830](#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[#34829](#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[#34827](#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[#34824](#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[#34823](#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[#34796](#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[#34792](#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[#34754](#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[#34712](#34712))
github-actions bot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
@pull
React DevTools 7.0.0 -> 7.0.1 (facebook#34926)
3adcdcf 
Full list of changes:

* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[facebook#34925](facebook#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[facebook#34915](facebook#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[facebook#34913](facebook#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34921](facebook#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34922](facebook#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34918](facebook#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[facebook#34916](facebook#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34907](facebook#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[facebook#34898](facebook#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34893](facebook#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34892](facebook#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34885](facebook#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34881](facebook#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34894](facebook#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34880](facebook#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34876](facebook#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34878](facebook#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34873](facebook#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34870](facebook#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34869](facebook#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34867](facebook#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [facebook#34860](facebook#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34861](facebook#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34859](facebook#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34854](facebook#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34853](facebook#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34852](facebook#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34851](facebook#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34850](facebook#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34828](facebook#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[facebook#34756](facebook#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34830](facebook#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34829](facebook#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34827](facebook#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34824](facebook#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34823](facebook#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[facebook#34796](facebook#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[facebook#34792](facebook#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[facebook#34754](facebook#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[facebook#34712](facebook#34712))

DiffTrain build for [3cde211](facebook@3cde211)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Oct 24, 2025
@pull
React DevTools 7.0.0 -> 7.0.1 (facebook#34926)
5901f42 
Full list of changes:

* Text layout fixes for stack traces with badges
([eps1lon](https://github.com/eps1lon) in
[facebook#34925](facebook#34925))
* chore: read from build/COMMIT_SHA fle as fallback for commit hash
([hoxyq](https://github.com/hoxyq) in
[facebook#34915](facebook#34915))
* fix: dont ship source maps for css in prod builds
([hoxyq](https://github.com/hoxyq) in
[facebook#34913](facebook#34913))
* Lower case "rsc stream" debug info
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34921](facebook#34921))
* BuiltInCallSite should have padding-left
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34922](facebook#34922))
* Show the Suspense boundary name in the rect if there's no overlap
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34918](facebook#34918))
* Don't attach filtered IO to grandparent Suspense
([eps1lon](https://github.com/eps1lon) in
[facebook#34916](facebook#34916))
* Infer name from stack if it's the generic "lazy" name
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34907](facebook#34907))
* Use same Suspense naming heuristics when reconnecting
([eps1lon](https://github.com/eps1lon) in
[facebook#34898](facebook#34898))
* Assign a different color and label based on environment
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34893](facebook#34893))
* Compute environment names for the timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34892](facebook#34892))
* Don't highlight the root rect if no roots has unique suspenders
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34885](facebook#34885))
* Highlight the rect when the corresponding timeline bean is hovered
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34881](facebook#34881))
* Repeat the "name" if there's no short description in groups
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34894](facebook#34894))
* Tweak the rects design and create multi-environment color scheme
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34880](facebook#34880))
* Adjust the rects size by one pixel smaller
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34876](facebook#34876))
* Remove steps title from scrubber
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34878](facebook#34878))
* Include some sub-pixel precision in rects
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34873](facebook#34873))
* Don't pluralize if already plural
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34870](facebook#34870))
* Don't try to load anonymous or empty urls
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34869](facebook#34869))
* Add inspection button to Suspense tab
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34867](facebook#34867))
* Don't select on hover ([sebmarkbage](https://github.com/sebmarkbage)
in [facebook#34860](facebook#34860))
* Don't highlight on timeline
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34861](facebook#34861))
* The bridge event types should only be defined in one direction
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34859](facebook#34859))
* Attempt at a better "unique suspender" text
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34854](facebook#34854))
* Track whether a boundary is currently suspended and make transparent
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34853](facebook#34853))
* Don't hide overflow rectangles
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34852](facebook#34852))
* Measure text nodes ([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34851](facebook#34851))
* Don't measure fallbacks when suspended
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34850](facebook#34850))
* Filter out built-in stack frames
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34828](facebook#34828))
* Exclude Suspense boundaries in hidden Activity
([eps1lon](https://github.com/eps1lon) in
[facebook#34756](facebook#34756))
* Group consecutive suspended by rows by the same name
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34830](facebook#34830))
* Preserve the original index when sorting suspended by
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34829](facebook#34829))
* Don't show the root as being non-compliant
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34827](facebook#34827))
* Ignore suspense boundaries, without visual representation, in the
timeline ([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34824](facebook#34824))
* Explicitly say which id to scroll to and only once
([sebmarkbage](https://github.com/sebmarkbage) in
[facebook#34823](facebook#34823))
* devtools: fix ellipsis truncation for key values
([sophiebits](https://github.com/sophiebits) in
[facebook#34796](facebook#34796))
* fix(devtools): remove duplicated "Display density" field in General
settings ([Anatole-Godard](https://github.com/Anatole-Godard) in
[facebook#34792](facebook#34792))
* Gate SuspenseTab ([hoxyq](https://github.com/hoxyq) in
[facebook#34754](facebook#34754))
* Release `<ViewTransition />` to Canary
([eps1lon](https://github.com/eps1lon) in
[facebook#34712](facebook#34712))

DiffTrain build for [3cde211](facebook@3cde211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoxyq @eps1lon