Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 20, 2025

Fixes #33630

During the mutation phase, we disabled the event emitter. This caused onReset to be dropped when we automatically reset the form when a Form Action finishes. Controlled inputs would not have been reset if they're reset during onReset.

This could be implemented by scheduling the state updates from the Form Action instead. Arguably a footgun since you have to consider both now.

People could already work around by listening to the native reset event.

@meta-cla meta-cla bot added the CLA Signed label Nov 20, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Nov 20, 2025
@react-sizebot
Copy link

Comparing: 8ac5f4e...16c78d7

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.02% 608.36 kB 608.46 kB +0.01% 107.68 kB 107.70 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.05% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.01% 667.47 kB 667.57 kB +0.01% 117.57 kB 117.58 kB
facebook-www/ReactDOM-prod.classic.js +0.01% 693.67 kB 693.76 kB +0.01% 122.06 kB 122.08 kB
facebook-www/ReactDOM-prod.modern.js +0.01% 684.10 kB 684.19 kB +0.01% 120.45 kB 120.46 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 16c78d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: onReset is not called during automatic form reset

2 participants