[Fizz] Model SuspenseList with tail="hidden" and tail="collapsed" as virtual boundaries #35191
+1,023
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to keep track of a list that need rows added to it. It's also used as a marker on the SuspenseBoundary if the boundary is an implicit boundary added around each row in a tail hidden/collapsed.
This will allow us to skip past a SuspenseList's rows when hydrating it if we don't yet have all the rows satisfied.
…ith potentially hidden rows
Assuming we didn't emit comments around every row.
The complex part about this mode is that we can't release the previous row until we have a loading state for the next row. So we make the implicit boundary of the next row block the preceeding row. But since that also blocks the next implicit boundary, there's a cycle that needs special handling.
github-actions
bot
added
the
React Core Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a special list marker around the SuspenseList in these modes and wraps each row in an implicit Suspense boundary nested in each other. We can use this implicit boundary to keep track of whether that row has fully loaded and to hide the content of that row when previous ones block it from appearing.
This currently can't land by itself because it emits comment nodes for the Suspense boundaries which the client doesn't expect.
Next I'm going to remove those nodes and build a special runtime for appending instead of replacing these to make it more optimal to render many items.