Fixes #35193 : Add runtime type check before calling useEffect cleanup functions

[Darshan-Naik]

Fixes #35193

Summary

Adds runtime type checks to prevent crashes when non-function cleanup values are stored in effect hooks. This fixes the regression in React 19.x where returning null from useEffect causes TypeError: destroy is not a function during cleanup.

Currently, React only validates cleanup return values in DEV mode during effect mount, but doesn't check before calling cleanup during unmount in production.

Problem

When a non-function value (like null) is stored in inst.destroy, React attempts to call it during unmount, causing TypeError: destroy is not a function crashes in production.

Current behavior:

• DEV mode: Warns when effect returns non-function (mount time) ✅
• Production: No runtime check before calling cleanup → crashes ❌

Related Issue: #35193

Solution

Added typeof destroy === 'function' checks in two places:

1. commitHookEffectListUnmount (line 267): Wraps cleanup execution in type check to prevent unnecessary profiling overhead
2. safelyCallDestroy (line 917): Defensive check as a safety net

Changes

• Added runtime type check before calling cleanup functions
• Prevents profiling markers from being set for non-function values
• Silently skips non-function cleanup values (no crashes)
• Fixes the regression where returning null from useEffect causes crashes

Testing

• Code follows React's style guidelines
• Changes are minimal and focused
• Existing tests pass (needs verification)

Code References

• File: packages/react-reconciler/src/ReactFiberCommitEffects.js
• Function: commitHookEffectListUnmount (lines 248-302)
• Function: safelyCallDestroy (lines 914-938)

[meta-cla]

Hi @Darshan-Naik!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!