Skip to content

Conversation

@eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 26, 2025

Same as #33634 but for use and promise-as-a-child.

An alternative to re-rendering would've been to eagerly collect use() calls but we know Error() is slow in v8. The danger with lazily collecting use() is that the Thenable may be resolved on retry.

The shown stack relies on sourcemaps with ignoreList. Otherwise it'll point into React internals. From the dispatcher we wouldn't know how many stacks we have to cut without a circular dependency to the React.use function. We would also need to distinguish between React.use and promise-as-a-child.

A dedicated dispatcher would only work for use and not promise-as-a-child.

@meta-cla meta-cla bot added the CLA Signed label Nov 26, 2025
@eps1lon eps1lon force-pushed the sebbie/fizz-thenable-abort branch from ccb260e to 9e7c24e Compare November 26, 2025 14:52
@eps1lon eps1lon force-pushed the sebbie/fizz-thenable-abort branch from 9e7c24e to 3200a65 Compare November 26, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant