[DevTools] Fix console links not being openable #35229
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draft so I don't accidentally merge.
Fixes #33983 (comment)
See https://issues.chromium.org/u/1/issues/462747680
Seems like
chrome.devtools.panels.openResourceis not actually the default behavior for the resource handler. It's erroring when trying to open URLs that don't point to Chrome Resources and not doing anything. Will bring this up with Chrome but until then we should have a workaround.E.g. clicking on
https://google.comdoes nothing.Falling back to
window.openin caseopenResourceerrors. https://developer.chrome.com/docs/extensions/reference/api/devtools/panels#method-openResource doesn't document the parameter to the callback but it returns an error-like object.Test plan
Click on the link from
console.log('https://google.com'). File links also work (e.g.console.log('file://404'))