Skip to content

Playground: Refactor messages types and parsing (string enums, readonly) #35482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monokkai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Playground: Refactor messages types and parsing (string enums, readonly) #35482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions compiler/apps/playground/lib/stores/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,34 @@
*/

export enum MessageSource {
Babel,
Forget,
Playground,
Babel = 'Babel',
Forget = 'Forget',
Playground = 'Playground',
}

export enum MessageLevel {
Info,
Warning,
Error,
Info = 'info',
Warning = 'warning',
Error = 'error',
}

export interface Message {
title: string;
level: MessageLevel;
source: MessageSource; // Can be used to further style messages differently.
codeframe: string | undefined;
readonly title: string;
readonly level: MessageLevel;
readonly source: MessageSource; // Can be used to further style messages differently.
readonly codeframe?: string;
}

export function createMessage(
message: string,
level: MessageLevel,
source: MessageSource,
): Message {
const [title, ...body] = message.split('\n');
const codeframe = body.length > 0 ? body.join('\n') : undefined;
const normalized = message.replace(/\r\n/g, '\n').trimEnd();
const [titleRaw, ...body] = normalized.split('\n');
const title = titleRaw.trim();
const codeframeRaw = body.join('\n').trim();
const codeframe = codeframeRaw === '' ? undefined : codeframeRaw;

return {
source,
Expand Down