[flags] add enableEffectEventMutationPhase#35548
Merged
rickhanlonii merged 5 commits intofacebook:mainfrom Feb 4, 2026
Merged
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: 087a346...bc2bbc7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
rickhanlonii
commented
Jan 17, 2026
rickhanlonii
commented
Jan 18, 2026
| }); | ||
|
|
||
| // @gate enableActivity | ||
| it('effect events are fresh in deeply nested hidden Activities', async () => { |
rickhanlonii
force-pushed
the
rh/uee-mutation-2
branch
from
91749bd to
cd267f4
Compare
jackpope
approved these changes
Jan 22, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…35555) Related to #35548, `enableViewTransition` fixes a bug where `getSnapshotBeforeUpdate` was running in hidden trees when it shouldn't (`componentWillUpdate` won't run for hidden updates, and when it becomes visible it will be called with `componentWillMount`). DiffTrain build for [087a346](087a346)
rickhanlonii
force-pushed
the
rh/uee-mutation-2
branch
from
7c628b7 to
65967dc
Compare
rickhanlonii
force-pushed
the
rh/uee-mutation-2
branch
from
d5f8bf0 to
bc2bbc7
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Small optimization for useEffectEvent. Not sure we even need a flag for it, but it will be a nice killswitch. As an added benefit, it fixes a bug when `enableViewTransition` is on, where we were not updating the useEffectEvent callback when a tree went from hidden to visible. DiffTrain build for [3aaab92](3aaab92)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
Small optimization for useEffectEvent. Not sure we even need a flag for it, but it will be a nice killswitch. As an added benefit, it fixes a bug when `enableViewTransition` is on, where we were not updating the useEffectEvent callback when a tree went from hidden to visible. DiffTrain build for [3aaab92](3aaab92)
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimization for useEffectEvent. Not sure we even need a flag for it, but it will be a nice killswitch.
As an added benefit, it fixes a bug when
enableViewTransitionis on, where we were not updating the useEffectEvent callback when a tree went from hidden to visible.