Skip to content

[DevTools] Throw an error when attempting to clone non-existent node #35702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoxyq merged 1 commit into from
Feb 5, 2026
+8 −5
Merged

[DevTools] Throw an error when attempting to clone non-existent node #35702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/react-devtools-shared/src/devtools/views/Profiler/CommitTreeBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,14 @@ function updateTree(

// Clone nodes before mutating them so edits don't affect them.
const getClonedNode = (id: number): CommitTreeNode => {
// $FlowFixMe[prop-missing] - recommended fix is to use object spread operator
const clonedNode = ((Object.assign(
{},
nodes.get(id),
): any): CommitTreeNode);
const existingNode = nodes.get(id);
if (existingNode == null) {
throw new Error(
`Could not clone the node: commit tree does not contain fiber "${id}". This is a bug in React DevTools.`,
);
}

const clonedNode = {...existingNode};
nodes.set(id, clonedNode);
return clonedNode;
};
Expand Down
Loading