Fix Windows path separator issue in Rust tests #5128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rust tests were failing on Windows because PathBuf's Debug implementation uses backslashes on Windows but the test snapshots expect forward slashes. This adds a custom Debug implementation for ArtifactRecord that normalizes path separators to forward slashes for cross-platform consistency. Fixes 61 failing tests in relay_compiler_relay_compiler_integration_test on Windows.
The previous fix in artifact_map.rs wasn't being used. The actual path formatting happens in ProjectArtifactMap's Debug impl in compiler_state.rs. This normalizes the path separators when formatting the artifact map for test output.
Contributor
Author
|
This was created as a validation of #5129. I already had a better hand-crafted fix in D90190629 |
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Summary: Now you can open Calude in the Relay repo and run `/fix-ci` to have Claude attempt to fix any CI issues. Example PR created with this command: #5128 Pull Request resolved: #5129 Reviewed By: evanyeung Differential Revision: D90196913 Pulled By: captbaritone fbshipit-source-id: 817dcda33cb17b4fdea6efc2d4c98d645208a75a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 61 failing Rust integration tests on Windows by normalizing path separators in artifact map debug output.
Problem
The Rust tests in
relay_compiler_relay_compiler_integration_testwere failing on Windows with snapshot mismatches like:This occurred because
PathBuf'sDebugimplementation uses platform-native path separators (backslashes on Windows), but the test snapshots expect forward slashes for cross-platform consistency.Solution
Added a custom
Debugimplementation forArtifactRecordincompiler/crates/relay-compiler/src/artifact_map.rsthat:to_string_lossy()Testing
This fix targets the Windows-specific test failures. CI will verify:
Related
Fixes CI failures visible in recent runs on the
mainbranch.