IsFastCrc32Supported: Print the correct arch when not supported #14217
+54
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When crc32 was not supported and compiled for aarch64, RocksDB logs "Not supported on x86". Change to "Not supported on Arm64". Add a unit test for the function. For aarch64: Switch from the deprecated __ARM_FEATURE_CRYPTO macro to the finer-grained __ARM_FEATURE_AES macro, which determines if the pmull instruction is supported. Use these instead of HAVE_* since they are well documented and supported by Clang and GCC. The deprecation notice for __ARM_FEATURE_CRYPTO: https://arm-software.github.io/acle/main/acle.html#crypto-extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When crc32 was not supported and compiled for aarch64, RocksDB logs "Not supported on x86". Change to "Not supported on Arm64".
Add a unit test for the function.
For aarch64: Switch from the deprecated
__ARM_FEATURE_CRYPTOmacro to the finer-grained__ARM_FEATURE_AESmacro, which determines if the pmull instruction is supported. Use these instead ofHAVE_*since they are well documented and supported by Clang and GCC.The deprecation notice for
__ARM_FEATURE_CRYPTO:https://arm-software.github.io/acle/main/acle.html#crypto-extension