Skip to content

Conversation

@hemal-shah
Copy link

Change adds log_data_ function callback for when iterating over a WriteBatch. Previously only the Put, Delete, Merge operations were called into when iterating over an WriteBatch (and their *_cf equivalent through a different WriteBatch::Handler implementation).

To maintain backwards compatibility, previously exported function definitions remain the same, but new functions are exported for different languages to use the LogData callback on an iteration.

Background

Hi - we use the rust-rocksdb bindings to work with rocksdb at Stripe. We are starting to make small contributions #14183 & #14136 and this adds on top of it. I saw that the PutLogData method is already exported for a WriteBatch, but there's no way to consume that. This change allows us to consume that information (with a follow up change on the rust-rocksdb repo.).

Thanks for your time looking into this. Previously we had trouble with meta's internal linters - I am happy to make appropriate change if something like that pops up again.

Note

FYI - I am on a vacation for the next week, so I wouldn't be able to make follow-up changes until 01/26/2026 (hopefully the PR wouldn't close automatically by then).

Change adds `log_data_` function callback for when iterating over a `WriteBatch`. Previously only the `Put`, `Delete`, `Merge` operations were called into when iterating over an `WriteBatch` (and their `*_cf` equivalent through a different `WriteBatch::Handler` implementation).

To maintain backwards compatibility, previously exported function definitions remain the same, but new functions are exported for different languages to use the `LogData` callback on an iteration.
@meta-cla
Copy link

meta-cla bot commented Jan 16, 2026

Hi @hemal-shah!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@hemal-shah
Copy link
Author

Signed CLA. Probably will take 1 hour to reflect on the failing check as per documentation.

@meta-cla meta-cla bot added the CLA Signed label Jan 16, 2026
@meta-cla
Copy link

meta-cla bot commented Jan 16, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants