Add WriteBatch::Handler::LogData iteration callback function
#14245
+59
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change adds
log_data_function callback for when iterating over aWriteBatch. Previously only thePut,Delete,Mergeoperations were called into when iterating over anWriteBatch(and their*_cfequivalent through a differentWriteBatch::Handlerimplementation).To maintain backwards compatibility, previously exported function definitions remain the same, but new functions are exported for different languages to use the
LogDatacallback on an iteration.Background
Hi - we use the
rust-rocksdbbindings to work withrocksdbat Stripe. We are starting to make small contributions #14183 & #14136 and this adds on top of it. I saw that thePutLogDatamethod is already exported for aWriteBatch, but there's no way to consume that. This change allows us to consume that information (with a follow up change on therust-rocksdbrepo.).Thanks for your time looking into this. Previously we had trouble with meta's internal linters - I am happy to make appropriate change if something like that pops up again.
Note
FYI - I am on a vacation for the next week, so I wouldn't be able to make follow-up changes until 01/26/2026 (hopefully the PR wouldn't close automatically by then).