Require StarlarkTypeRepr for AllocFrozenValue

Summary: Used in the following diff D47173723.

Reviewed By: ndmitchell

Differential Revision: D47173718

fbshipit-source-id: ec3c80efd762ae4d432cb87facc0db8fceebb10a

Author: stepancheg

starlark/src/values/alloc_value.rs

@@ -92,7 +92,7 @@ impl<A: AllocFrozenValue, B: AllocFrozenValue> AllocFrozenValue for Either<A, B>
 }
 
 /// Trait for things that can be allocated on a [`FrozenHeap`] producing a [`FrozenValue`].
-pub trait AllocFrozenValue {
+pub trait AllocFrozenValue: StarlarkTypeRepr {
     /// Allocate a value in the frozen heap and return a reference to the allocated value.
     fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue;
 }

starlark/src/values/owned.rs

@@ -24,7 +24,9 @@ use dupe::Clone_;
 use dupe::Dupe;
 use dupe::Dupe_;
 
+use crate::typing::Ty;
 use crate::values::none::NoneType;
+use crate::values::type_repr::StarlarkTypeRepr;
 use crate::values::AllocFrozenValue;
 use crate::values::FrozenHeap;
 use crate::values::FrozenHeapRef;
@@ -60,6 +62,12 @@ impl Display for OwnedFrozenValue {
     }
 }
 
+impl StarlarkTypeRepr for OwnedFrozenValue {
+    fn starlark_type_repr() -> Ty {
+        FrozenValue::starlark_type_repr()
+    }
+}
+
 impl AllocFrozenValue for OwnedFrozenValue {
     fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue {
         // Safe because this is the standard expectation for alloc_frozen_value

starlark/src/values/types/dict/value.rs

@@ -123,6 +123,12 @@ impl<'v> AllocValue<'v> for Dict<'v> {
     }
 }
 
+impl StarlarkTypeRepr for FrozenDictData {
+    fn starlark_type_repr() -> Ty {
+        Ty::dict(Ty::Any, Ty::Any)
+    }
+}
+
 impl AllocFrozenValue for FrozenDictData {
     fn alloc_frozen_value(self, heap: &FrozenHeap) -> FrozenValue {
         if self.content.is_empty() {

starlark/src/values/types/list/value.rs

@@ -239,9 +239,9 @@ impl<V: AllocFrozenValue> AllocFrozenValue for Vec<V> {
     }
 }
 
-impl<'a, 'v, V: 'a> StarlarkTypeRepr for &'a [V]
+impl<'a, V: 'a> StarlarkTypeRepr for &'a [V]
 where
-    &'a V: AllocValue<'v> + StarlarkTypeRepr,
+    &'a V: StarlarkTypeRepr,
 {
     fn starlark_type_repr() -> Ty {
         Vec::<&'a V>::starlark_type_repr()

starlark/src/values/types/structs/alloc.rs

@@ -57,11 +57,10 @@ impl AllocStruct<iter::Empty<(String, String)>> {
     pub const EMPTY: AllocStruct<iter::Empty<(String, String)>> = AllocStruct(iter::empty());
 }
 
-impl<'v, K, V, S> StarlarkTypeRepr for AllocStruct<S>
+impl<K, V, S> StarlarkTypeRepr for AllocStruct<S>
 where
     S: IntoIterator<Item = (K, V)>,
-    K: AllocStringValue<'v>,
-    V: AllocValue<'v>,
+    V: StarlarkTypeRepr,
 {
     fn starlark_type_repr() -> Ty {
         Struct::starlark_type_repr()

starlark/src/values/types/tuple/alloc.rs

@@ -48,10 +48,9 @@ impl AllocTuple<iter::Empty<FrozenValue>> {
     pub const EMPTY: AllocTuple<iter::Empty<FrozenValue>> = AllocTuple(iter::empty());
 }
 
-impl<'v, T> StarlarkTypeRepr for AllocTuple<T>
+impl<T> StarlarkTypeRepr for AllocTuple<T>
 where
     T: IntoIterator,
-    T::Item: AllocValue<'v>,
 {
     fn starlark_type_repr() -> Ty {
         Ty::name(TupleRef::TYPE)