Add ARM's assembly code for huffman decoding #4204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Would be good to add PAC and BTI support, #3961 could be referred for adding BTI description in section |
Contributor
|
The latest Given that newer compilers perform just as well or better, and the maintenance burden of adding more assembly, we will not be merging this upstream. Adding non-x86-64 assembly makes it very hard to fuzz test the code. And down the line I would love to also delete the x86-64 assembly. Maintaining assembly in Zstd has ended up being a huge PITA, due to the huge number of platforms & compilers we support. Thanks for the PR @Nicoshev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to have a dedicated ARM's asm function for decoding huffman