Accept G, GB and GiB suffixes for options#4609
Merged
Cyan4973 merged 2 commits intofacebook:devfrom Mar 13, 2026
Merged
Conversation
Integral-Tech
force-pushed
the
memory-g-suffix
branch
from
4ac1481 to
652f584
Compare
jlee303
requested changes
Mar 6, 2026
Contributor
jlee303
left a comment
jlee303
left a comment
There was a problem hiding this comment.
Looking good, just a few suggestions, thanks for putting up a pr 😄
Integral-Tech
force-pushed
the
memory-g-suffix
branch
from
652f584 to
a3263a1
Compare
Integral-Tech
force-pushed
the
memory-g-suffix
branch
from
a3263a1 to
f282305
Compare
Integral-Tech
changed the title
--memory option
jlee303
approved these changes
Mar 9, 2026
Integral-Tech
force-pushed
the
memory-g-suffix
branch
2 times, most recently
from
66530ec to
f403390
Compare
Integral-Tech
force-pushed
the
memory-g-suffix
branch
from
f403390 to
488b3a7
Compare
Contributor
Author
|
@jlee303 Resolved :) Could you please approve the workflows again? |
Contributor
Cyan4973
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several options currently accept only K, KB, KiB, M, MB and MiB suffixes. This change adds support for G, GB and GiB so users can specify gigabyte values using the same suffix styles.
Closes: #4540