This repository was archived by the owner on May 16, 2023. It is now read-only.
Open
Conversation
for seems redundant. builds, ->builds ,Release ->Space added
snarkmaster
suggested changes
Oct 7, 2019
Contributor
snarkmaster
left a comment
snarkmaster
left a comment
There was a problem hiding this comment.
Thanks for reading through this! Would you mind rolling back the {Debug,Release} change?
|
|
||
| This README is a very abbreviated introduction to Bistro. Visit | ||
| http://facebook.github.io/bistro for a more structured introduction, and for the docs. | ||
| http://facebook.github.io/bistro for a more structured introduction, and the docs. |
Contributor
There was a problem hiding this comment.
This is not a grammar fix, but a style preference. To me, having 2 "for" clauses is more clear. But if you feel passionate about this, do it your way.
| various flavors of Linux and Mac OS. | ||
|
|
||
| The binaries will be in `bistro/cmake/{Debug,Release}`. Available build | ||
| The binaries will be in `bistro/cmake/{Debug, Release}`. Available build |
Contributor
There was a problem hiding this comment.
Let's not change this. The {foo,bar} syntax has clear significance to anybody who uses a Bourne-style shell. Adding whitespace here changes the meaning. This is not a good fix, since the Release directory does not, in fact, have a leading space.
| If you run into dependency problems, look at `bistro/cmake/setup.cmake` for | ||
| a full list of Bistro's external dependencies (direct and indirect). We | ||
| gratefully accept patches that improve Bistro's builds, or add support for | ||
| gratefully accept patches that improve Bistro's builds or add support for |
Contributor
There was a problem hiding this comment.
This is a good catch, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for seems redundant.
builds, ->builds
,Release ->Space added