You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Added ability to perform both record new image and compare with old one at the same time.
When i am reported about some diff in snapshots by the build server, sometimes i know that there was a small change in color, font or image asset. In this case i only want to regenerate my ref images. But during regeneration i really want to know that no other minor changes was made between test run on a build server and generation. It would be good to generate diffs of old ref images with a potential new one.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!
hmm I've been think about this for a while, I am not really sure how this property will be used. Can you provide some examples on how this will be integrated with your CI tooling?
The main idea is to make the process of creating new ref screenshots easier.
For example my CI reports that there is some differences in screenshots. I've checked and see that the font was changed, but this is ok, as it was changed in the "common lib" project. At that point I'd like to recreate the ref screenshots with new font used. I can do it either manually or automatically on CI, but in any case I'd like to be sure that the only difference in new screenshots is the font. The easiest way to do so is to have diffs also on this stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to perform both record new image and compare with old one at the same time.
When i am reported about some diff in snapshots by the build server, sometimes i know that there was a small change in color, font or image asset. In this case i only want to regenerate my ref images. But during regeneration i really want to know that no other minor changes was made between test run on a build server and generation. It would be good to generate diffs of old ref images with a potential new one.