Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Commit 7c4fa51

Browse files
author
Fosco Marotto
committed
Merge pull request #87 from facebook/gFosco.apptoken
Removed appToken from test credentials file.
2 parents 7c00055 + 9bac482 commit 7c4fa51

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

tests/FacebookRequestTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public function testCanPostAndDelete()
3131
);
3232
$response = (
3333
new FacebookRequest(
34-
new FacebookSession(FacebookTestCredentials::$appToken),
34+
new FacebookSession(FacebookTestHelper::getAppToken()),
3535
'POST',
3636
'/' . FacebookTestCredentials::$appId . '/accounts/test-users',
3737
$params
@@ -42,7 +42,7 @@ public function testCanPostAndDelete()
4242
// Delete test user
4343
$response = (
4444
new FacebookRequest(
45-
new FacebookSession(FacebookTestCredentials::$appToken),
45+
new FacebookSession(FacebookTestHelper::getAppToken()),
4646
'DELETE',
4747
'/' . $user_id
4848
))->execute()->getGraphObject()->asArray();

tests/FacebookSessionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ public static function setUpBeforeClass()
1313

1414
public function testSessionToken()
1515
{
16-
$session = new FacebookSession(FacebookTestCredentials::$appToken);
16+
$session = new FacebookSession(FacebookTestHelper::getAppToken());
1717
$this->assertEquals(
18-
FacebookTestCredentials::$appToken, $session->getToken()
18+
FacebookTestHelper::getAppToken(), $session->getToken()
1919
);
2020
}
2121

tests/FacebookTestCredentials.php.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ class FacebookTestCredentials {
88
*/
99
public static $appId = '';
1010
public static $appSecret = '';
11-
public static $appToken = '';
1211

1312
}
1413

tests/FacebookTestHelper.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ class FacebookTestHelper
1212
public static function setUpBeforeClass()
1313
{
1414
if (!strlen(FacebookTestCredentials::$appId) ||
15-
!strlen(FacebookTestCredentials::$appSecret) ||
16-
!strlen(FacebookTestCredentials::$appToken)) {
15+
!strlen(FacebookTestCredentials::$appSecret)) {
1716
throw new FacebookSDKException(
1817
'You must fill out FacebookTestCredentials.php'
1918
);
@@ -52,11 +51,16 @@ public static function createTestSession()
5251
'method' => 'post'
5352
);
5453
$response = (new FacebookRequest(
55-
new FacebookSession(FacebookTestCredentials::$appToken),
54+
new FacebookSession(FacebookTestHelper::getAppToken()),
5655
'GET',
5756
$testUserPath,
5857
$params))->execute()->getGraphObject();
5958
return new FacebookSession($response->getProperty('access_token'));
6059
}
6160

61+
public static function getAppToken()
62+
{
63+
return FacebookTestCredentials::$appId . '|' . FacebookTestCredentials::$appSecret;
64+
}
65+
6266
}

tests/GraphSessionInfoTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public function testSessionInfo()
1818
'input_token' => FacebookTestHelper::$testSession->getToken()
1919
);
2020
$response = (new FacebookRequest(
21-
new FacebookSession(FacebookTestCredentials::$appToken),
21+
new FacebookSession(FacebookTestHelper::getAppToken()),
2222
'GET',
2323
'/debug_token',
2424
$params

0 commit comments

Comments
 (0)