circleci: drop #520
Merged
circleci: drop #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2024
CircleCI is no longer an option for a facebookexperimental repo and our builds are now failing because they rely on larger runners that are only available with paid accounts. Drop CircleCI. We lose coverage by doing this, but the testing is covered appropriately by GitHub Actions. Will try to follow up with PRs that re-enable coverage. Test plan: - CI
tyroguru
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI is no longer an option for a facebookexperimental repo and our builds
are now failing because they rely on larger runners that are only available with
paid accounts. Drop CircleCI.
We lose coverage by doing this, but the testing is covered appropriately by
GitHub Actions. Will try to follow up with PRs that re-enable coverage.
Test plan:
Stack created with Sapling. Best reviewed with ReviewStack.