Re-enable Flow tests in OSS CI with split test suites#693
Open
phlalx wants to merge 1 commit intofacebookincubator:mainfrom
Open
Re-enable Flow tests in OSS CI with split test suites#693phlalx wants to merge 1 commit intofacebookincubator:mainfrom
phlalx wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: D91738264 split the Flow and Hack tests into smaller targets to avoid CI timeout/OOM issues, but the OSS CI was subsequently disabled in D92338196. This diff re-enables the Flow tests in OSS CI by: 1. Removing `-f-flow-tests` from the disabled test flags in both CI workflows 2. Splitting the `glass-regression-flow` test suite into 7 smaller suites using an m4 macro 3. Adding a `test-flow-glass` Makefile target that iterates over the split tests The split test suites mirror the internal Buck targets: - flow-describe, flow-document, flow-references, flow-resolve - flow-search-basic, flow-search-prefix, flow-search-prefix-empty Differential Revision: D92395770
✅ Deploy Preview for fb-oss-glean canceled.
|
meta-cla
bot
added
the
CLA Signed
Contributor
Collaborator
|
Hey @phlalx, I wasn't aware that this test was slow, has it got slower recently? Could there be a regression, or something dumb going on to make it slow? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D91738264 split the Flow and Hack tests into smaller targets to avoid CI timeout/OOM issues, but the OSS CI was subsequently disabled in D92338196.
This diff re-enables the Flow tests in OSS CI by:
-f-flow-testsfrom the disabled test flags in both CI workflowsglass-regression-flowtest suite into 7 smaller suites using an m4 macrotest-flow-glassMakefile target that iterates over the split testsThe split test suites mirror the internal Buck targets:
Differential Revision: D92395770