Skip to content

Commit 4c4fa99

Browse files
vmagrometa-codesync[bot]
authored andcommitted
[antlir2][image_test] fix /dev/null test
Summary: This didn't start with `test_` so was never actually run... Test Plan: ``` ❯ buck2 test fbcode//antlir/antlir2/testing/tests: -- dev_null Buck UI: https://www.internalfb.com/buck2/213286ba-372c-4c11-84fb-091de9b73934 Network: Up: 169KiB Down: 278KiB (reSessionID-9884d4b9-018c-42b0-9547-a7be2ad6bdfc) Analyzing targets. Remaining 0/34 34 actions Executing actions. Remaining 0/664 9:17.1s exec time total Command: test. Finished 388 local Time elapsed: 40.2s Tests finished: Pass 24. Fail 0. Fatal 0. Skip 0. Omit 0. Infra Failure 0. Build failure 0 ``` https://www.internalfb.com/intern/testinfra/testrun/5066549913236818 Reviewed By: justintrudell Differential Revision: D89397424 fbshipit-source-id: 93a130137af738af0b5f646f0430e3bb204be28c
1 parent 46414fd commit 4c4fa99

File tree

1 file changed

+2
-2
lines changed
  • antlir/antlir2/testing/tests

1 file changed

+2
-2
lines changed

antlir/antlir2/testing/tests/test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ def test_env_propagated(self) -> None:
2525
def test_json_env_quoting(self) -> None:
2626
self.assertEqual({"foo": "bar"}, json.loads(os.getenv("JSON_ENV")))
2727

28-
def dev_null(self) -> None:
28+
def test_dev_null(self) -> None:
2929
st = os.stat("/dev/null")
3030
self.assertTrue(st.st_mode & stat.S_IFCHR, "/dev/null should be char device")
3131
self.assertEqual(
32-
st.st_rdev & stat.S_IFCHR,
32+
st.st_rdev,
3333
os.makedev(1, 3),
3434
"/dev/null device number is wrong",
3535
)

0 commit comments

Comments
 (0)