refactor: Rename velox casting utilities to camelCase convention#333
Open
juwentus1234 wants to merge 1 commit intofacebookincubator:mainfrom
Open
refactor: Rename velox casting utilities to camelCase convention#333juwentus1234 wants to merge 1 commit intofacebookincubator:mainfrom
juwentus1234 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: Renamed three function templates in velox's casting utilities to follow the camelCase naming convention: - `checked_pointer_cast` → `checkedPointerCast` - `static_unique_pointer_cast` → `staticUniquePointerCast` - `is_instance_of` → `isInstanceOf` This change affects the function definitions in `/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.h` and all call sites within the velox codebase and related projects that use velox namespaced functions. Files updated: - Function definitions in `velox/common/Casts.h` - Velox core files: `core/PlanNode.cpp`, `exec/Exchange.cpp`, `exec/Task.cpp`, `common/memory/MemoryPool.cpp`, `tool/trace/TopNRowNumberReplayer.cpp` - Test file: `velox/common/testutil/tests/CastsTest.cpp` - updated all test cases - DataInfra/Sequence files that use `facebook::velox::` namespace prefix (8 files) This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations. Differential Revision: D87806227
meta-cla
bot
added
the
CLA Signed
|
@juwentus1234 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87806227. |
juwentus1234
added a commit
to juwentus1234/velox
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebookincubator/nimble#333 Renamed three function templates in velox's casting utilities to follow the camelCase naming convention: - `checked_pointer_cast` → `checkedPointerCast` - `static_unique_pointer_cast` → `staticUniquePointerCast` - `is_instance_of` → `isInstanceOf` This change affects the function definitions in `/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.h` and all call sites within the velox codebase and related projects that use velox namespaced functions. Files updated: - Function definitions in `velox/common/Casts.h` - Velox core files: `core/PlanNode.cpp`, `exec/Exchange.cpp`, `exec/Task.cpp`, `common/memory/MemoryPool.cpp`, `tool/trace/TopNRowNumberReplayer.cpp` - Test file: `velox/common/testutil/tests/CastsTest.cpp` - updated all test cases - DataInfra/Sequence files that use `facebook::velox::` namespace prefix (8 files) This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations. Differential Revision: D87806227
juwentus1234
added a commit
to juwentus1234/presto
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebookincubator/velox#15614 X-link: facebookincubator/nimble#333 Renamed three function templates in velox's casting utilities to follow the camelCase naming convention: - `checked_pointer_cast` → `checkedPointerCast` - `static_unique_pointer_cast` → `staticUniquePointerCast` - `is_instance_of` → `isInstanceOf` This change affects the function definitions in `/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.h` and all call sites within the velox codebase and related projects that use velox namespaced functions. Files updated: - Function definitions in `velox/common/Casts.h` - Velox core files: `core/PlanNode.cpp`, `exec/Exchange.cpp`, `exec/Task.cpp`, `common/memory/MemoryPool.cpp`, `tool/trace/TopNRowNumberReplayer.cpp` - Test file: `velox/common/testutil/tests/CastsTest.cpp` - updated all test cases - DataInfra/Sequence files that use `facebook::velox::` namespace prefix (8 files) This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations. Differential Revision: D87806227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Renamed three function templates in velox's casting utilities to follow the camelCase naming convention:
checked_pointer_cast→checkedPointerCaststatic_unique_pointer_cast→staticUniquePointerCastis_instance_of→isInstanceOfThis change affects the function definitions in
/data/users/ericjjj/fbsource/fbcode/velox/common/Casts.hand all call sites within the velox codebase and related projects that use velox namespaced functions.Files updated:
velox/common/Casts.hcore/PlanNode.cpp,exec/Exchange.cpp,exec/Task.cpp,common/memory/MemoryPool.cpp,tool/trace/TopNRowNumberReplayer.cppvelox/common/testutil/tests/CastsTest.cpp- updated all test casesfacebook::velox::namespace prefix (8 files)This refactoring improves consistency with velox's naming conventions while maintaining backward compatibility with external codebases that use their own implementations.
Differential Revision: D87806227