Open
Conversation
Summary: Introducing stream level deduplication. With this change, before writing streams to a stripe, we are identifying streams that are byte-identical and only write one copy of the stream to the file. All other identical streams will store the same offset and size as the original stream. To opt-in for this behavior, a new option was introduced: streamDeduplicationEnabled. C++ reader was modified to identify if streams are duplicated and only load them once. Selective reader seems to already handle this read deduplication. Java was not modified. It is loading the same stream multiple times (which is not a regression over what we currently have). Differential Revision: D88087515
Summary: Hooking up stream dedup to dwio file writer. Also added a kill switch just knob: dwio/nimble:enable_stream_deduplication Differential Revision: D88087517
Summary: Needed for latest rename in Velox Differential Revision: D88317373
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Needed for latest rename in Velox
Differential Revision: D88317373