Enable raw size consistency check conditionally#465
Open
HuamengJiang wants to merge 2 commits intofacebookincubator:mainfrom
Open
Enable raw size consistency check conditionally#465HuamengJiang wants to merge 2 commits intofacebookincubator:mainfrom
HuamengJiang wants to merge 2 commits intofacebookincubator:mainfrom
Conversation
added 2 commits
February 4, 2026 02:12
Summary: When making changes in stats collection path and now cross validating raw/logical size calculation from vector and field writer collection, we found some test failures in feature reaper tests due to test data specifying inconsistent input vector type and schema type. The writer supports this upcast implicitly otherwise, so the right thing to do is to support it in a lightweight fashion. We do still have to fix the test case where it tried to pass integer to a float column. Differential Revision: D91559828
Summary: As we went through the current validations, we can start to deprecate the current top level raw size accounting from the input vector and use the logical size from root column stats instead. We do so via a flag in writer options, which can then be wired up in the different downstream call sites. Still leaves the flag on for continuous e2e validation (vader). Differential Revision: D91559827
meta-cla
bot
added
the
CLA Signed
|
@HuamengJiang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91559827. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As we went through the current validations, we can start to deprecate the current top level raw size accounting from the input vector and use the logical size from root column stats instead. We do so via a flag in writer options, which can then be wired up in the different downstream call sites.
Still leaves the flag on for continuous e2e validation (vader).
Differential Revision: D91559827