Skip to content

fix: Print verbose errors in cudf deps updater#16332

Open
mhaseeb123 wants to merge 5 commits intofacebookincubator:mainfrom
mhaseeb123:update/update-cudf-deps.sh
Open

fix: Print verbose errors in cudf deps updater#16332
mhaseeb123 wants to merge 5 commits intofacebookincubator:mainfrom
mhaseeb123:update/update-cudf-deps.sh

Conversation

@mhaseeb123
Copy link
Collaborator

@mhaseeb123 mhaseeb123 commented Feb 10, 2026

Description

This PR updates the update-cudf-deps.sh to not silently exit without any message or effect when, for example, read fails due to GH rate limiting and throws a verbose message such as

Error: Failed to fetch VERSION file from branch main
  Try: `gh auth login` (or set GH_TOKEN) before running this script
  Create a GitHub personal access token at https://github.com/settings/tokens/new
  (Select scope: public_repo)

@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit f1610e6
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/69b4bbf636cbd30008b6d74b

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 10, 2026
@mhaseeb123 mhaseeb123 requested a review from bdice February 10, 2026 23:53
@mhaseeb123 mhaseeb123 changed the title fix(cudf): cudf dependency updater script to not silently exit fix(cudf): cudf dependency updater script throws verbose errors Feb 10, 2026
@mhaseeb123 mhaseeb123 changed the title fix(cudf): cudf dependency updater script throws verbose errors fix(cudf): cudf dependency updater throws verbose errors Feb 10, 2026
@mhaseeb123 mhaseeb123 changed the title fix(cudf): cudf dependency updater throws verbose errors fix(cudf): cudf deps updater throws verbose errors Feb 12, 2026
@mhaseeb123 mhaseeb123 changed the title fix(cudf): cudf deps updater throws verbose errors fix: cudf dependency updater throws verbose errors Feb 12, 2026
@mhaseeb123 mhaseeb123 changed the title fix: cudf dependency updater throws verbose errors fix: cudf deps updater throws verbose errors Feb 12, 2026
@mhaseeb123 mhaseeb123 changed the title fix: cudf deps updater throws verbose errors fix: Throws verbose errors in cudf deps updater Feb 12, 2026
@mhaseeb123 mhaseeb123 changed the title fix: Throws verbose errors in cudf deps updater fix: Print verbose errors in cudf deps updater Feb 12, 2026
@mhaseeb123 mhaseeb123 marked this pull request as ready for review March 3, 2026 04:12
Copy link
Collaborator

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently I used this approach for a “maybe curl, maybe gh” style. Might help simplify the code if you think using gh for authentication when available is sufficient, rather than taking an environment variable.

fetch_github_api() {
    local endpoint=$1
    if command -v gh &>/dev/null; then
        gh api "${endpoint}" 2>/dev/null && return
    fi
    curl -sf "https://api.github.com/${endpoint}"
}

@devavret devavret added the cudf cudf related - GPU acceleration label Mar 12, 2026
@mhaseeb123 mhaseeb123 requested a review from devavret March 14, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cudf cudf related - GPU acceleration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants