Skip to content

feat: Add America/Coyhaique timezone support #16362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n0r0shi wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −2
Open

feat: Add America/Coyhaique timezone support #16362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions velox/type/tz/TimeZoneDatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,6 +2265,7 @@ const std::vector<std::pair<int16_t, std::string>>& getTimeZoneEntries() {
{2231, "Pacific/Kanton"},
{2232, "Europe/Kyiv"},
{2233, "America/Ciudad_Juarez"},
{2234, "America/Coyhaique"},
};
}());
return *tzDB;
Expand Down
5 changes: 5 additions & 0 deletions velox/type/tz/TimeZoneNames.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,11 @@ const std::unordered_map<std::string, TimeZoneNames>& getTimeZoneNames() {
{"Greenwich Mean Time", "GMT", "Greenwich Mean Time", "GMT"}},
{"America/Costa_Rica",
{"Central Standard Time", "CST", "Central Daylight Time", "CDT"}},
{"America/Coyhaique",
{"Coyhaique Standard Time",
"GMT-03:00",
"Coyhaique Daylight Time",
"GMT-03:00"}},
{"America/Grand_Turk",
{"Eastern Standard Time", "EST", "Eastern Daylight Time", "EDT"}},
{"America/Guadeloupe",
Expand Down
4 changes: 2 additions & 2 deletions velox/type/tz/gen_timezone_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
#include <unordered_map>
#include <vector>

namespace facebook::velox::util {
namespace facebook::velox::tz {

const std::vector<std::pair<int16_t, std::string>>& getTimeZoneEntries() {
static auto* tzDB = new std::vector<std::pair<int16_t, std::string>>([] {
Expand All @@ -64,7 +64,7 @@
return *tzDB;
}

} // namespace facebook::velox::util\
} // namespace facebook::velox::tz\
"""
)

Expand Down
3 changes: 3 additions & 0 deletions velox/type/tz/tests/TimeZoneMapTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ TEST(TimeZoneMapTest, locateZoneID) {
EXPECT_EQ(2141, locateZoneID("Pacific/Marquesas"));
EXPECT_EQ(2215, locateZoneID("Asia/Chita"));
EXPECT_EQ(2233, locateZoneID("America/Ciudad_Juarez"));
EXPECT_EQ(2234, locateZoneID("America/Coyhaique"));
}

TEST(TimeZoneMapTest, locateZoneUTCAlias) {
Expand Down Expand Up @@ -165,6 +166,7 @@ TEST(TimeZoneMapTest, getTimeZoneName) {
EXPECT_EQ("Pacific/Kanton", getTimeZoneName(2231));
EXPECT_EQ("Europe/Kyiv", getTimeZoneName(2232));
EXPECT_EQ("America/Ciudad_Juarez", getTimeZoneName(2233));
EXPECT_EQ("America/Coyhaique", getTimeZoneName(2234));
EXPECT_EQ("-00:01", getTimeZoneName(840));
EXPECT_EQ("UTC", getTimeZoneName(0));
}
Expand All @@ -175,6 +177,7 @@ TEST(TimeZoneMapTest, getTimeZoneID) {
EXPECT_EQ(2231, getTimeZoneID("Pacific/Kanton"));
EXPECT_EQ(2232, getTimeZoneID("Europe/Kyiv"));
EXPECT_EQ(2233, getTimeZoneID("America/Ciudad_Juarez"));
EXPECT_EQ(2234, getTimeZoneID("America/Coyhaique"));
EXPECT_EQ(0, getTimeZoneID("UTC"));
EXPECT_EQ(0, getTimeZoneID("GMT"));
EXPECT_EQ(0, getTimeZoneID("Z"));
Expand Down
Loading