build: Upgrade Velox DuckDB from 0.8.1 to 1.4.4 (#16650)#16650
Open
hdikeman wants to merge 1 commit intofacebookincubator:mainfrom
Open
build: Upgrade Velox DuckDB from 0.8.1 to 1.4.4 (#16650)#16650hdikeman wants to merge 1 commit intofacebookincubator:mainfrom
hdikeman wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
bot
added
the
CLA Signed
hdikeman
force-pushed
the
export-D95309313
branch
from
6475d75 to
f2ff7d3
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 5, 2026
) Summary: Pull Request resolved: facebookincubator#16650 Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
f2ff7d3 to
57424c1
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 5, 2026
) Summary: Pull Request resolved: facebookincubator#16650 Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
2 times, most recently
from
a287a55 to
92e9e5a
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 6, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
92e9e5a to
cc96eed
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 11, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 11, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
2 times, most recently
from
b0a607b to
f1525d7
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 12, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 12, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
f1525d7 to
10f9657
Compare
meta-codesync
bot
changed the title
hdikeman
force-pushed
the
export-D95309313
branch
from
10f9657 to
bafa9de
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
2 times, most recently
from
b88a001 to
15a85fc
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
15a85fc to
8b6960d
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 13, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
8b6960d to
bdcccba
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 14, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
bdcccba to
caad865
Compare
hdikeman
added a commit
to hdikeman/velox
that referenced
this pull request
Mar 14, 2026
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
caad865 to
0999128
Compare
) Summary: Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4 Updates needed: - Update default duckdb alias in third-party/duckdb/BUCK to point to 1.4.4 - Replace manually-copied DuckDB class definitions in DuckLogicalOperator.h with direct includes of v1.4.4 headers, since this was to work around DuckDB being so old - Fix API compatibility in QueryPlanner.cpp: - LogicalGet::column_ids is now private; use GetColumnIds()/ColumnIndex - LogicalLimit uses BoundLimitNode instead of int64_t - TableFunction::to_string signature changed to use TableFunctionToStringInput - Aggregate function callback signatures gained AggregateFunction& parameter - Handle new LOGICAL_UNNEST operator type (split from LogicalGet) - Fix DuckParser.cpp: - Handle new OPERATOR_TRY expression type (was parsed as function before) - Handle new WindowBoundary GROUPS variants - Support INTERVAL constants parsed directly by DuckDB 1.4.4 - Unwrap cast(trunc(cast(...))) chains in interval parsing - Fix QueryAssertions.cpp: Value::EMPTYLIST removed; use Value::LIST - Update CMake/CI: version, commit hash, and ccache patch for v1.4.4 Differential Revision: D95309313
hdikeman
force-pushed
the
export-D95309313
branch
from
0999128 to
0ad2a97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrade DuckDB dependency for Velox from v0.8.1 to v1.4.4
Updates needed:
Differential Revision: D95309313