feat: Add ANSI mode support for unaryminus overflow detection#16672
Open
n0r0shi wants to merge 1 commit intofacebookincubator:mainfrom
Open
feat: Add ANSI mode support for unaryminus overflow detection#16672n0r0shi wants to merge 1 commit intofacebookincubator:mainfrom
n0r0shi wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Make unaryminus config-based: when spark.ansi.enabled is true, negating the minimum value of an integer type throws an arithmetic overflow error.
✅ Deploy Preview for meta-velox canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unaryminusconfig-based: whenspark.ansi.enabledis true, negating the minimum value of an integer type (e.g.,-(-128)for tinyint) throws an arithmetic overflow error instead of silently returning the minimum valueabs, which already readssparkAnsiEnabledfromQueryConfigPicks up the
unaryminusportion from #16361, which has been inactive.Test plan
UnaryMinustests pass (normal cases unaffected)