docs: Add blog post about hidden traps of regex in LIKE and split#16673
Closed
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Closed
docs: Add blog post about hidden traps of regex in LIKE and split#16673mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
Summary: Blog post explaining how LIKE and Spark's split use regex under the hood, leading to correctness bugs and performance traps when patterns or delimiters come from columns. Discusses why raising the compiled regex limit is the wrong fix and what users and engine developers should do instead. Differential Revision: D95671491
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95671491. |
meta-cla
bot
added
the
CLA Signed
amitkdutta
approved these changes
Mar 7, 2026
Contributor
amitkdutta
left a comment
amitkdutta
left a comment
There was a problem hiding this comment.
Great write up. Thanks @mbasmanova
|
This pull request has been merged in acbb96c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Blog post explaining how LIKE and Spark's split use regex under the hood,
leading to correctness bugs and performance traps when patterns or delimiters
come from columns. Discusses why raising the compiled regex limit is the wrong
fix and what users and engine developers should do instead.
Differential Revision: D95671491