Skip to content

Update release build workflow#329

Closed
neuralsorcerer wants to merge 3 commits intofacebookresearch:mainfrom
neuralsorcerer:release
Closed

Update release build workflow#329
neuralsorcerer wants to merge 3 commits intofacebookresearch:mainfrom
neuralsorcerer:release

Conversation

@neuralsorcerer
Copy link
Collaborator

@neuralsorcerer neuralsorcerer commented Feb 9, 2026

Updated the release workflow to build wheels with python -m build instead of deprecated setup.py in both test and deploy jobs.

Copilot AI review requested due to automatic review settings February 9, 2026 13:27
@meta-cla meta-cla bot added the cla signed label Feb 9, 2026
@neuralsorcerer neuralsorcerer deleted the release branch February 9, 2026 13:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release GitHub Actions workflow for the balance Python package to use modern PEP 517/518 builds via python -m build, replacing deprecated direct setup.py invocations.

Changes:

  • Added an Unreleased (0.17.x) changelog entry noting the workflow packaging update.
  • Switched the release workflow’s test and deploy jobs from setup.py wheel builds to python -m build.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
CHANGELOG.md Adds an Unreleased entry documenting the workflow packaging change and updates release notes formatting.
.github/workflows/release.yml Replaces setup.py build commands with python -m build in both test and deploy jobs.

@neuralsorcerer neuralsorcerer restored the release branch February 9, 2026 14:22
@neuralsorcerer neuralsorcerer reopened this Feb 9, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 9, 2026

@talgalili has imported this pull request. If you are a Meta employee, you can view this in D92711564.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

@neuralsorcerer
Copy link
Collaborator Author

@talgalili sorry my bad. The current commit in the main branch is correct. We need to update here

@neuralsorcerer
Copy link
Collaborator Author

We can close this PR.

@neuralsorcerer neuralsorcerer deleted the release branch February 9, 2026 14:57
@talgalili
Copy link
Contributor

@neuralsorcerer the current main branch solution is not working.
https://github.com/facebookresearch/balance/blob/0.16.0/.github/workflows/release.yml

I'm landing the current PR (the one you just closed - it's about to be landed).
Should I cancel the land?

@neuralsorcerer
Copy link
Collaborator Author

Please cancel this land.

@neuralsorcerer
Copy link
Collaborator Author

Created new PR #332

@talgalili
Copy link
Contributor

@neuralsorcerer I stopped the land.
Could you please fix this so it would work - in the current PR?

@neuralsorcerer
Copy link
Collaborator Author

neuralsorcerer commented Feb 9, 2026

@talgalili We need to push the changes in main branch to 0.16 tagged version

@talgalili
Copy link
Contributor

@neuralsorcerer I removed the 0.16 tag.
You tell me when I can land this - once I do - I'll re-release 0.16

@talgalili
Copy link
Contributor

@neuralsorcerer so to clarify, it's fine that I'll land:
#329
And then create a 0.16 tag?

@neuralsorcerer
Copy link
Collaborator Author

@talgalili the current commit in the main branch is good. No need to land this PR. Previously, the release was created before the fix to main branch, that's why the deploy was failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants