Update release build workflow#329
Update release build workflow#329neuralsorcerer wants to merge 3 commits intofacebookresearch:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release GitHub Actions workflow for the balance Python package to use modern PEP 517/518 builds via python -m build, replacing deprecated direct setup.py invocations.
Changes:
- Added an Unreleased (0.17.x) changelog entry noting the workflow packaging update.
- Switched the release workflow’s test and deploy jobs from
setup.pywheel builds topython -m build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
CHANGELOG.md |
Adds an Unreleased entry documenting the workflow packaging change and updates release notes formatting. |
.github/workflows/release.yml |
Replaces setup.py build commands with python -m build in both test and deploy jobs. |
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D92711564. |
|
@talgalili sorry my bad. The current commit in the main branch is correct. We need to update here |
|
We can close this PR. |
|
@neuralsorcerer the current main branch solution is not working. I'm landing the current PR (the one you just closed - it's about to be landed). |
|
Please cancel this land. |
|
Created new PR #332 |
|
@neuralsorcerer I stopped the land. |
|
@talgalili We need to push the changes in main branch to 0.16 tagged version |
|
@neuralsorcerer I removed the 0.16 tag. |
|
@neuralsorcerer so to clarify, it's fine that I'll land: |
|
@talgalili the current commit in the main branch is good. No need to land this PR. Previously, the release was created before the fix to main branch, that's why the deploy was failing. |
Updated the release workflow to build wheels with
python -m buildinstead of deprecatedsetup.pyin both test and deploy jobs.