Fix weight diagnostics for DataFrame inputs#335
Closed
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Fix weight diagnostics for DataFrame inputs#335neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes inconsistent handling of weight diagnostics when weights are provided as a pd.DataFrame, by normalizing supported weight inputs to a single pd.Series (using the first DataFrame column) before validation and computation.
Changes:
- Added
_weights_to_series(...)helper to normalizelist/ndarray/Series/DataFrameweight inputs (with explicit error for empty DataFrames). - Updated
design_effect,nonparametric_skew,prop_above_and_below, andweighted_median_breakdown_pointto route computation through_weights_to_series(...). - Expanded test coverage to ensure consistent behavior across
list/ndarray/Series/DataFrameinputs and improved failure modes for empty/invalid DataFrames.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
balance/stats_and_plots/weights_stats.py |
Adds _weights_to_series normalization and applies it across weight diagnostic functions. |
tests/test_stats_and_plots.py |
Adds tests for DataFrame-first-column behavior, empty DataFrame errors, and list/ndarray parity. |
CHANGELOG.md |
Documents the bug fix under the upcoming release notes. |
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D93216988. |
|
@talgalili merged this pull request in ca5a837. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_weights_to_series(...)and routing validation/computation through it so DataFrame weight inputs are consistently normalized to their first column. This was applied todesign_effect,nonparametric_skew,prop_above_and_below, andweighted_median_breakdown_point.