Add full warning assertions for Sample.from_frame id inference#337
Closed
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Add full warning assertions for Sample.from_frame id inference#337neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR strengthens test coverage around Sample.from_frame()’s ID inference path by asserting that all expected warning logs are emitted during automatic id detection and default weight creation.
Changes:
- Updated
test_Sample_from_frame_id_column_detectionto capture logs from a singleSample.from_frame(df)call and assert presence of all three expected warning messages. - Added a changelog entry noting expanded warning-assertion coverage for this behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/test_sample.py |
Captures warning logs during Sample.from_frame() ID inference and asserts all expected messages are present. |
CHANGELOG.md |
Documents the expanded test assertions for Sample.from_frame() ID inference warnings. |
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D93365012. |
|
@talgalili merged this pull request in e2fe1ec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added full warning assertions for
Sample.from_frameid inference