Handle duplicate-column suffix collisions in pandas utils#347
Closed
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Closed
Handle duplicate-column suffix collisions in pandas utils#347neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
neuralsorcerer wants to merge 2 commits intofacebookresearch:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in _make_df_column_names_unique() where duplicate column renaming could collide with existing suffixed column names (e.g., when columns ["a", "a_1", "a"] exist, the second a would be renamed to a_1, colliding with the existing a_1). The fix introduces collision detection that increments the suffix until a unique name is found.
Changes:
- Enhanced
_make_df_column_names_unique()to track used names and avoid suffix collisions - Added comprehensive test coverage for collision scenarios, non-string columns, and the no-op path
- Added test coverage for object dtype handling in
_safe_fillna_and_infer() - Removed obsolete TODO comment about inconsistent behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| balance/utils/pandas_utils.py | Added used_names set tracking and collision-avoidance loop in _make_df_column_names_unique() |
| tests/test_util_pandas_utils.py | Added three new tests for collision handling, non-string columns, and already-unique columns; removed TODO comment; added object dtype test for _safe_fillna_and_infer() |
| CHANGELOG.md | Documented the bug fix under "Bug Fixes" section |
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D94329024. |
|
@talgalili merged this pull request in bd1c5bc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.