Skip to content

Cast boxes to double when scores.dtype == torch.float64 #5479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Cast boxes to double when scores.dtype == torch.float64 #5479

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68064dd
Cast `boxes` to double when `scores.dtype == torch.float64`
anmyachev Jul 15, 2025
aa1ce37
Update detectron2/layers/nms.py
anmyachev Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion detectron2/layers/nms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ def batched_nms(
# to decide whether to use coordinate trick or for loop to implement batched_nms. So we
# just call it directly.
# Fp16 does not have enough range for batched NMS, so adding float().
return box_ops.batched_nms(boxes.float(), scores, idxs, iou_threshold)
if scores.dtype == torch.float64:
res = box_ops.batched_nms(boxes.double(), scores, idxs, iou_threshold)
Copy link

@TotallyReal TotallyReal Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put the whole line in the if statement and not just the actual value that depends on it? For example:

boxes_value = boxes.double() if scores.data == torch.float64 else boxes.float()
return box_ops.batched_nms(boxes_value, scores, idxs, iou_threshold)

Copy link
Author

@anmyachev anmyachev Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

else:
res = box_ops.batched_nms(boxes.float(), scores, idxs, iou_threshold)
return res


# Note: this function (nms_rotated) might be moved into
Expand Down