Remove use of __AMDGCN_WAVEFRONT_SIZE macro with it being deprecated in ROCm 7#4619
Remove use of __AMDGCN_WAVEFRONT_SIZE macro with it being deprecated in ROCm 7#4619kevinjoseph1995 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
…in ROCm 7 Summary: Usage of __AMDGCN_WAVEFRONT_SIZE is a compilation error when using amdclang++ shipped with ROCm 7.x.x. For versions >= 7 we delegate to rocprim to get the right constexpr value that can be used in __device__ code. We continue using __AMDGCN_WAVEFRONT_SIZE for older ROCm versions to maintain compatibility. Note that the usage of kWarpSize in host code is still non-sensical however the current usage of this variable seems to always be in __device__ functions. See https://rocm.docs.amd.com/en/latest/about/release-notes.html#amdgpu-wavefront-size-compiler-macro-deprecation for deprecation notice.
|
Hi @kevinjoseph1995! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thanks for this contribution @kevinjoseph1995! |
|
Got it, thanks for letting me know! I’ll wait for the ROCm runner to be back online. |
Summary:
Usage of
__AMDGCN_WAVEFRONT_SIZEis a compilation error when using amdclang++ shipped with ROCm 7.x.x. For versions >= 7 we delegate to rocprim to get the right constexpr value that can be used in device code. We continue using __AMDGCN_WAVEFRONT_SIZE for older ROCm versions to maintain compatibility.Note that the usage of kWarpSize in host code is still non-sensical however the current usage of this variable seems to always be in device functions.
See https://rocm.docs.amd.com/en/latest/about/release-notes.html#amdgpu-wavefront-size-compiler-macro-deprecation for deprecation notice.