Add benchmark to measure the ResultHandler overhead#4778
Closed
mdouze wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Add benchmark to measure the ResultHandler overhead#4778mdouze wants to merge 1 commit intofacebookresearch:mainfrom
mdouze wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Contributor
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Jan 30, 2026
…#4778) Summary: There seems to be a performance regression in Faiss after the ResultHandler's introduction. This test attemtps to reproduce it. It is difficult to run fine-grained benchmarks on devservers (when trying to spot a 1% regression), but here are the results: before inlined scanner: P2154463854 after inlined scanner: P2154465531 Especially very fast distance computations (like Flat with small dimensions) clearly benefit from it. Reviewed By: junjieqi Differential Revision: D91784507
mdouze
force-pushed
the
export-D91784507
branch
from
9ff48f8 to
890e426
Compare
…#4778) Summary: There seems to be a performance regression in Faiss after the ResultHandler's introduction. This test attemtps to reproduce it. It is difficult to run fine-grained benchmarks on devservers (when trying to spot a 1% regression), but here are the results: before inlined scanner: P2154463854 after inlined scanner: P2154465531 Especially very fast distance computations (like Flat with small dimensions) clearly benefit from it. Reviewed By: junjieqi Differential Revision: D91784507
mdouze
force-pushed
the
export-D91784507
branch
from
890e426 to
155bd4c
Compare
Contributor
|
This pull request has been merged in 4e4c4c7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There seems to be a performance regression in Faiss after the ResultHandler's introduction.
This test attemtps to reproduce it.
Differential Revision: D91784507