Skip tasks with insufficient samples for pass@k instead of raising ex…#113
Open
Skip tasks with insufficient samples for pass@k instead of raising ex…#113
Conversation
…ception When computing pass@k metrics with k > 1, tasks that have fewer than k samples are now gracefully skipped with a warning log message instead of raising a ValueError that would terminate the entire results processing. Changes: - Replace ValueError with warning log when n_samples < k for a task - Add logging module import and logger instance - Collect skipped groups and log them with full context (dataset, agent, attack, task_id, and sample count) - Add check for empty DataFrame after filtering in aggregate_results - Update docstrings to reflect new behavior (Note instead of Raises) - Also includes refactoring: remove job_name from group_cols to allow aggregating across multiple runs of the same experiment - Add generic variant_name support alongside legacy template_short_name
Collaborator
|
I fear this might lead to silently computing wrong metrics? Should we have a non-strict mode that behaves like this via a flag instead? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
#113) Summary: When computing pass@k metrics with k > 1, tasks that have fewer than k samples are now gracefully skipped with a warning log message instead of raising a ValueError that would terminate the entire results processing. Changes: - Replace ValueError with warning log when n_samples < k for a task - Add logging module import and logger instance - Collect skipped groups and log them with full context (dataset, agent, attack, task_id, and sample count) - Add check for empty DataFrame after filtering in aggregate_results - Update docstrings to reflect new behavior (Note instead of Raises) - Also includes refactoring: remove job_name from group_cols to allow aggregating across multiple runs of the same experiment - Add generic variant_name support alongside legacy template_short_name Differential Revision: D92393526 Pulled By: evtimovi
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
#113) Summary: When computing pass@k metrics with k > 1, tasks that have fewer than k samples are now gracefully skipped with a warning log message instead of raising a ValueError that would terminate the entire results processing. Changes: - Replace ValueError with warning log when n_samples < k for a task - Add logging module import and logger instance - Collect skipped groups and log them with full context (dataset, agent, attack, task_id, and sample count) - Add check for empty DataFrame after filtering in aggregate_results - Update docstrings to reflect new behavior (Note instead of Raises) - Also includes refactoring: remove job_name from group_cols to allow aggregating across multiple runs of the same experiment - Add generic variant_name support alongside legacy template_short_name Differential Revision: D92393526 Pulled By: evtimovi
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
#113) Summary: When computing pass@k metrics with k > 1, tasks that have fewer than k samples are now gracefully skipped with a warning log message instead of raising a ValueError that would terminate the entire results processing. Changes: - Replace ValueError with warning log when n_samples < k for a task - Add logging module import and logger instance - Collect skipped groups and log them with full context (dataset, agent, attack, task_id, and sample count) - Add check for empty DataFrame after filtering in aggregate_results - Update docstrings to reflect new behavior (Note instead of Raises) - Also includes refactoring: remove job_name from group_cols to allow aggregating across multiple runs of the same experiment - Add generic variant_name support alongside legacy template_short_name Differential Revision: D92393526 Pulled By: evtimovi
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
#113) Summary: When computing pass@k metrics with k > 1, tasks that have fewer than k samples are now gracefully skipped with a warning log message instead of raising a ValueError that would terminate the entire results processing. Changes: - Replace ValueError with warning log when n_samples < k for a task - Add logging module import and logger instance - Collect skipped groups and log them with full context (dataset, agent, attack, task_id, and sample count) - Add check for empty DataFrame after filtering in aggregate_results - Update docstrings to reflect new behavior (Note instead of Raises) - Also includes refactoring: remove job_name from group_cols to allow aggregating across multiple runs of the same experiment - Add generic variant_name support alongside legacy template_short_name Differential Revision: D92393526 Pulled By: evtimovi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing pass@k metrics with k > 1, tasks that have fewer than k samples are now gracefully skipped with a warning log message instead of raising a ValueError that would terminate the entire results processing.
Changes: