Clarify JSON annotation processing in fs.py#30
Open
yrrIsHere wants to merge 1 commit intofacebookresearch:mainfrom
Open
Clarify JSON annotation processing in fs.py#30yrrIsHere wants to merge 1 commit intofacebookresearch:mainfrom
yrrIsHere wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Updated comment to clarify that annotation files are multi-line JSON (JSONL) and adjusted JSON loading to process line-by-line.
yrrIsHere
requested review from
JasonZheng20,
rjanardhan3,
tuanh208 and
zyaoj
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated comment to clarify that annotation files are multi-line JSON (JSONL) and adjusted JSON loading to process line-by-line.
Why?
Please refer to my issue: #28.
Those annotation files claimed to be JSON but are actually JSONL, which makes downloading from s3 a little bit tricky.
How ?
I directly treat annotation files on s3 as JSONL files.
Test plan
After this modification, at least using
download_s3.pyis ok, including functiondownload_single_example,download_interaction_pair,download_samples_1gbanddownload_session_exploration.